[
https://issues.apache.org/struts/browse/STR-3009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40345
]
Paul Benedict commented on STR-3009:
------------------------------------
Let me take the solution back :-) The architecture is wrong. This is what I
think should be done:
1) Do not modify ForwardConfig. It's nothing but a mapping and does not
indicate the type of mapping, so it's wrong to assume it is a forward or
redirect (although it generally always is).
2) Do not add parameter adding directly to ActionForward. Although
ActionRedirect is a subclass of ActionForward, the hierarchy is wrong because a
redirect is not a philosophical subset of a forward. They are just differing
but similar technologies.
3) Create a new subclass between ActionMapping and ActionForward called
ActionParameterized and place the functionality there. Just take the code in
ActionRedirect and move it up the hierarchy.
> ActionRedirect from ForwardConfig not redirecting properly?
> -----------------------------------------------------------
>
> Key: STR-3009
> URL: https://issues.apache.org/struts/browse/STR-3009
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.3.5, 1.3.6
> Reporter: Jason Millard
>
> While migrating from Struts 1.2.9 to Struts 1.3.5, I noticed ActionRedirect
> was no longer redirecting as expected.
> In the Struts 1.2.9, in
> public ActionRedirect(ForwardConfig baseConfig)
> setRedirect was always being set to TRUE, like it is in every other
> constructor.
> However, as of Struts 1.3.5 it is now being configured as
> setRedirect(baseConfig.getRedirect());
> This seems to defeat the purpose of a ActionRedirect if you are trying to
> generate one from a
> mapping.findForward();
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
