[ 
https://issues.apache.org/struts/browse/STR-3021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_40787
 ] 

Niall Pemberton commented on STR-3021:
--------------------------------------

I agree with Henri's "surgical maintenance" approach - so +1 to applying the 
patch from me.

The other version of tiles is whats being developed under the tiles TLP - and 
used to be know here as "Standalone Tiles"  or "Tiles 2" - the aim was to 
separate out tiles so that it had no Struts dependency. But I'm under the 
impression its pretty much a complete re-write - so not sure wheher this is an 
issue or not and it would probably take one of the Tiles committers to be able 
to say. There is an integration module (still under development) here in Struts 
for Tiles2:

    http://svn.apache.org/viewvc/struts/struts1/trunk/tiles2/

But the equvalent functionality for this issue is probably in the tiles project:

   http://svn.apache.org/viewvc/tiles/framework/trunk/

> Tiles insert is evaluated twice if JSP error occures
> ----------------------------------------------------
>
>                 Key: STR-3021
>                 URL: https://issues.apache.org/struts/browse/STR-3021
>             Project: Struts 1
>          Issue Type: Bug
>          Components: Tiles
>    Affects Versions: 1.3.5
>         Environment: Tomcat 5.0
>            Reporter: Thomas Wilhelm
>             Fix For: 1.3.9, 1.4.0
>
>         Attachments: STR-3021.patch
>
>
> If an Exception is thrown in a tiles-included JSP the surrounding 
> tiles-insert is processes twice. This most presumably due to a bug in 
> TilesUtilImpl#doInclude(String uri, PageContext pageContext, boolean flush) 
> where the InvocationTargetException is handled incorrectly. Every exception 
> thrown from the executed inlcude-method will be throw wrapped into a 
> InvocationTargetException so that include-method as well as 
> pageContext.include(uri) is executed everytime a JSP-Error occures during an 
> inlcude.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to