[
https://issues.apache.org/struts/browse/STR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41324
]
Paul Benedict commented on STR-1674:
------------------------------------
I am on board with Michael and Niall. The cancel attribute should be the first
thing checked, and skip population if it is canceled. Aside the fact that this
enhancement is sound, I've seen many people on the boards who are always trying
to retain the form's original data on cancellation. This would be a great
change of behavior.
> isCancelled does not work as intended if ActionMapping does not have a form
> ---------------------------------------------------------------------------
>
> Key: STR-1674
> URL: https://issues.apache.org/struts/browse/STR-1674
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.1 Final
> Environment: Operating System: All
> Platform: All
> Reporter: Patrick Dumontel
> Priority: Minor
> Fix For: 1.4.0
>
>
> If the action mapping does not contain a form bean name, e.g.:
> <action path="/this/action"
> type="action.class.name"/>
> using isCancelled() in that action will always return false. The code in
> org.apache.struts.action.RequestProcessor.processPopulate returns if the form
> is null before setting the Globals.CANCEL_KEY attribute.
> It seems to me that since a request parameter is used to detect the cancel
> button (the return request.getParameter(Constants.CANCEL_KEY) != null line),
> the setting of the request attribute should not depend on whether the action
> mapping uses a form.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
