[
https://issues.apache.org/struts/browse/STR-3066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41419
]
Paul Benedict commented on STR-3066:
------------------------------------
Based on the feedback from other committers, the original implementation was
not optimal and can be enhancement. I propose adding to STR-286 and STR-1116
since this issue regards a population strategy. The DTD for the attributes will
accept one or many comma-separated values of "all | request | forward | include
| cancel". The default will be "all" and will wholly preserve backwards
compatibility.
> Cancellation to prevent form population
> ---------------------------------------
>
> Key: STR-3066
> URL: https://issues.apache.org/struts/browse/STR-3066
> Project: Struts 1
> Issue Type: Improvement
> Components: Core
> Affects Versions: 1.1 Final
> Environment: Operating System: All
> Platform: All
> Reporter: Paul Benedict
> Assignee: Paul Benedict
> Fix For: 1.4.0
>
>
> I have never come across one user mail or program code where people are
> retrieving values on cancellation. Is there any framework which allows this
> anyway? I categorize this as an irregular practice that should not be
> supported -- and the current situation is an oversight. The action is
> canceled, the form is part of the action, and so the form has no job which is
> very much implied by the canceling of validation.
> The main issue at hand is that a developer may mistakenly believe all form
> data is always validated. If a form is configured for validation, and the
> submission goes through "canceled", the form is still populated. The
> guarantee for validated data, however, is absent.
> Due to backwards compatibility concern, I recommend one of two solutions
> 1) A skipPopulationOnCancel property on AbstractPopulateForm (defaults to
> true)
> 2) Rework STR-286 to include a populate cancel option (not a default).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
