[ https://issues.apache.org/struts/browse/WW-1950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Holmes resolved WW-1950. ------------------------------ Resolution: Fixed Fix Version/s: 2.0.10 Fixed on the 2_0_X branch in SVN revision 565492. Fixed on the trunk (Struts 2.1) in SVN revision 565609. Thanks for the heads up and the test case! > UrlHelper.buildUrl does not output port even if forceAddSchemeHostAndPort > turned on (TestCase included) > ------------------------------------------------------------------------------------------------------- > > Key: WW-1950 > URL: https://issues.apache.org/struts/browse/WW-1950 > Project: Struts 2 > Issue Type: Bug > Components: Views > Affects Versions: 2.0.8 > Reporter: Sami Dalouche > Assignee: James Holmes > Fix For: 2.0.10, 2.1.0 > > > If you add this test to UrlHelperTest, you will find out that it fails.. > public void testForceAddSchemeHostAndPortWithNonStandardPort() throws > Exception { > String expectedUrl = > "http://localhost:9090/contextPath/path1/path2/myAction.action"; > Mock mockHttpServletRequest = new Mock(HttpServletRequest.class); > mockHttpServletRequest.expectAndReturn("getScheme", "http"); > mockHttpServletRequest.expectAndReturn("getServerName", "localhost"); > mockHttpServletRequest.expectAndReturn("getContextPath", > "/contextPath"); > mockHttpServletRequest.expectAndReturn("getServerPort", 9090); > Mock mockHttpServletResponse = new Mock(HttpServletResponse.class); > mockHttpServletResponse.expectAndReturn("encodeURL", expectedUrl, > expectedUrl); > String result = UrlHelper.buildUrl("/path1/path2/myAction.action", > (HttpServletRequest) mockHttpServletRequest.proxy(), > (HttpServletResponse)mockHttpServletResponse.proxy(), null, "http", true, > true, true); > assertEquals(expectedUrl, result); > mockHttpServletRequest.verify(); > } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.