[
https://issues.apache.org/struts/browse/WW-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_42501
]
Ted Husted commented on WW-2282:
--------------------------------
Thanks for doing this, Giovanni.
I reviewed the DIFF, and I agree that these changes would be worthwhile.
Are these changes being generated by a tool? If so, would they be easy to run
again later.
My concern is that we have a few dozen other patches to apply, and since these
changes touch so many files, there may be conflicts with the other patches.
Though, many seem to be one:one line substitutions, and so the patch system
might be smart enough to work around.
I do want to apply the changes, it's just a matter of timing.
-Ted.
> Apply patch to Struts2 core module on performance issues reported by FindBugs
> ------------------------------------------------------------------------------
>
> Key: WW-2282
> URL: https://issues.apache.org/struts/browse/WW-2282
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Actions
> Affects Versions: 2.1.0
> Reporter: Giovanni Azua Garcia
> Assignee: Ted Husted
> Priority: Minor
> Attachments: Struts2CorePerfPatch_ToRev590856.diff,
> Struts2CorePerfPatch_ToRev590856.zip
>
>
> Post to DEV list:
> Recently I was following some threads in the Struts users list about
> performance issues in S2 and was curious to look at Struts code. Running
> findBugs evidences many small improvements that would overall and cheaply
> improve S2 performance e.g.
> - In many places it is continuously creating large number of small objects by
> using new rather than valueOf.
> http://findbugs.sourceforge.net/bugDescriptions.html#DM_NUMBER_CTOR
> - FindBugs spotted several places using non static inner classes
> unnecessarily.
> - Also a few places use inneficiently keySet iterators on maps rather than
> using entrySet.
> - Calling toString on String types.
> Good idea probably adding findbugs to the pom reporting.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
