[
https://issues.apache.org/struts/browse/WW-1969?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wes Wannemacher updated WW-1969:
--------------------------------
Attachment: WW-1969.patch
Although I don't think this is a real fix, I did notice that if an instance of
Dispatcher is unavailable, there is a potential NPE. It looks like there is a
friendly error message attached to the thrown exception when someone is using a
tag w/o the filter being applied. But, the friendly message may never be
reached because the condition that would cause the exception to be thrown would
also cause an NPE before the friendly error could be reached.
I am not too familiar with TagUtils, so I don't want to commit this without
some review. That being said, do we really need to keep this issue open? It
seems more like a user error than a bug.
> Error in TagUtils (NullPointerException) when viewing a page which didn't go
> through Struts 2 interceptor stack
> ---------------------------------------------------------------------------------------------------------------
>
> Key: WW-1969
> URL: https://issues.apache.org/struts/browse/WW-1969
> Project: Struts 2
> Issue Type: Improvement
> Components: Plugin - Tags
> Affects Versions: 2.0.9
> Environment: Tomcat 4.1
> Java 1.4
> Struts 2 - Java 1.4 retrotranslated version
> Reporter: Cyril Gambis
> Priority: Critical
> Fix For: Future
>
> Attachments: WW-1969.patch
>
>
> I searched for that item and havn't find anything in JIRA. I think there may
> be a patch because it is quite a serious issue and it is a regression from
> Struts 2.0.5 as I read on some forum.
> With this bug, some HelloWorld tutorials don't work anymore.
> The stack trace is:
> Stacktrace:
> org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrappe
> r.java:467)
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:389)
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> root cause
> java.lang.NullPointerException
> org.apache.struts2.views.jsp.TagUtils.getStack(TagUtils.java:58)
> org.apache.struts2.views.jsp.StrutsBodyTagSupport.getStack(StrutsBodyTagSupport
> .java:54)
> org.apache.struts2.views.jsp.ComponentTagSupport.doStartTag(ComponentTagSupport
> .java:49)
> org.apache.jsp.WebContent.index_jsp._jspx_meth_s_005fhead_005f0(index_jsp.java:
> 155)
> org.apache.jsp.WebContent.index_jsp._jspService(index_jsp.java:77)
> org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
> org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
> org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
> javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
> I understand that if you access directly a jsp page containing a tag like
> s:text, s:a or s:url, which usually won't need for a value stack. A solution
> may be to have everything go through the struts 2 interceptor stack, but
> believe me, for legacy application it is sometimes not easy at all (one of my
> developer has work on this problem for 2 days, currently).
> Is there any patch, anywhere? Especially for the Java 1.4 version or Struts 2?
> Some links:
> http://forums.opensymphony.com/thread.jspa?messageID=155149𥸍
> http://www.mail-archive.com/[EMAIL PROTECTED]/msg57582.html
> Thanks!
> Cyril Gambis
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
