[
https://issues.apache.org/struts/browse/STR-3160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44529#action_44529
]
Antonio Petrelli commented on STR-3160:
---------------------------------------
Don't take me wrong Yannick, it is a bug and I want to correct this evening
(CET). But the TilesRequestProcessor is only a backport class to make it work
with Struts 1.2-coded applications.
Anyway even in your case a CoR implementation could be better and I strongly
suggest to upgrade your app.
But remember, this is a bug, I have no excuses :-D
> TilesRequestProcessor processTilesDefinition returns false when a definition
> has been processed
> -----------------------------------------------------------------------------------------------
>
> Key: STR-3160
> URL: https://issues.apache.org/struts/browse/STR-3160
> Project: Struts 1
> Issue Type: Bug
> Components: Tiles 2 Plugin
> Affects Versions: 1.4.0
> Reporter: Yannick Haudry
> Assignee: Antonio Petrelli
> Attachments: TilesRequestProcessor.patch
>
>
> Here is the code involved in TilesRequestProcessor.processTilesDefinition:
> if (container.isValidDefinition(definitionName, new Object[] {
> request,
> response })) {
> retValue = response.isCommitted();
> try {
> container.render(definitionName, new Object[] { request,
> response });
> } catch (TilesException e) {
> throw new ServletException("Cannot render definition '"
> + definitionName + "'");
> }
> } else {
> // ignore not found
> if (log.isDebugEnabled()) {
> log.debug("Cannot find definition '" + definitionName + "'");
> }
> }
> the response.isCommitted() statement seems to return 'false' but the retValue
> should be set to 'true'
> as a definition was found at this point..
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
