[
https://issues.apache.org/struts/browse/WW-2361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=44816#action_44816
]
Jorge Tapia commented on WW-2361:
---------------------------------
I'm having problems with this as I have some requests in UTF-8 (GWT interface)
and other requests using charset encoding ISO-8859-1.
I have 'UTF-8' in struts.xml so the requests with charset ISO-8859-1 are not
correctly understood because the Dispatcher is overwritting the HttpRequest
character encoding.
The suggested patch is working for me in version 2.0.11.2.
> the default request charEncoding always used.
> ---------------------------------------------
>
> Key: WW-2361
> URL: https://issues.apache.org/struts/browse/WW-2361
> Project: Struts 2
> Issue Type: Improvement
> Affects Versions: 2.0.11
> Reporter: Avatar Zhang
> Fix For: 2.2.x
>
>
> // SUGGESTION
> Index: Dispatcher.java
> ===================================================================
> --- Dispatcher.java (revision 602010)
> +++ Dispatcher.java (working copy)
> @@ -620,10 +620,16 @@
> }
>
> if (encoding != null) {
> - try {
> - request.setCharacterEncoding(encoding);
> - } catch (Exception e) {
> - LOG.error("Error setting character encoding to '" + encoding
> + "' - ignoring.", e);
> + String encoding2 = request.getCharacterEncoding();
> + if (encoding2 == null) {
> + try {
> + request.setCharacterEncoding(encoding);
> + LOG.info("Set Character Encoding to " + encoding + "!");
> + } catch (Exception e) {
> + LOG.error("Error setting character encoding to '" +
> encoding + "' - ignoring.", e);
> + }
> + } else {
> + LOG.info("Character Encoding is " + encoding2 + ".");
> }
> }
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
