[
https://issues.apache.org/struts/browse/STR-3174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=45343#action_45343
]
ori commented on STR-3174:
--------------------------
Thanks for the quick reply.
I have a custom implementation of Context which cleans up other resources using
release() (e.g., a JDBC Connection).
It is not urgent because I found it much easier to add a Filter to the
"servlet-standard" chain which invokes release() in its postprocess() method.
This guarantees the context will be cleaned up properly.
> ComposableRequestProcessor.process() should invoke Context's release() method
> inside a finally clause
> -----------------------------------------------------------------------------------------------------
>
> Key: STR-3174
> URL: https://issues.apache.org/struts/browse/STR-3174
> Project: Struts 1
> Issue Type: Bug
> Components: Core
> Affects Versions: 1.3.10
> Environment: n/a
> Reporter: ori
> Assignee: Paul Benedict
> Fix For: 1.4.0
>
>
> The process method in org.apache.struts.chain.ComposableRequestProcessor
> invokes release() on the ActionContext only on success.
> The release() method should be invoked regardless of the result of the
> execution.
> To fix, simply add a finally clause around the line like this:
> finally {
> context.release();
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
