[
https://issues.apache.org/struts/browse/STR-3192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46581#action_46581
]
Juan Carlos Blanco Martinez commented on STR-3192:
--------------------------------------------------
Is this a way for Struts to make sure that it works fine when in multi-thread
mode, no matter if the person overriding
org.apache.struts.util.MessageResources defines createResources(String
configuration) as synchronized or not?
In such a case it would make sense.
> Why lazy instantiation of the MessageResourcesFactory in Struts 1.2.7?
> ----------------------------------------------------------------------
>
> Key: STR-3192
> URL: https://issues.apache.org/struts/browse/STR-3192
> Project: Struts 1
> Issue Type: Improvement
> Affects Versions: 1.2.7
> Reporter: Juan Carlos Blanco Martinez
> Priority: Critical
>
> Since there is the Double-checked locking issue so we have to use
> synchronization to guarantee the concurrent access to the following method
> (org.apache.struts.util.MessageResources class) :
> LAZY INSTANTIATION
> public synchronized static MessageResources getMessageResources(String
> config) {
> if (defaultFactory == null) {
> defaultFactory = MessageResourcesFactory.createFactory();
> }
> return defaultFactory.createResources(config);
> }
> Why not to use:
> EAGER INSTANTIATION
> static {
> // Construct a new instance of the specified factory class
> try {
> if (clazz == null)
> clazz = RequestUtils.applicationClass(factoryClass);
> MessageResourcesFactory defaultFactory =
> (MessageResourcesFactory) clazz.newInstance();
> } catch (Throwable t) {
> LOG.error("MessageResourcesFactory.createFactory", t);
> }
> }
> And then:
> public static MessageResources getMessageResources(String config) {
> return defaultFactory.createResources(config);
> }
> It would allow concurrent access to the method getMessageResources which at
> least in my case it may be called quite a few times.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
