[
https://issues.apache.org/jira/browse/WW-3385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12834981#action_12834981
]
Erling Molde commented on WW-3385:
----------------------------------
Ooops! Blunder!
Yes, you're quite right. That's what I meant.
> (Application|Session|Request)Map.put(key,value) breaks Map-contract,
> returning new value, not old value
> -------------------------------------------------------------------------------------------------------
>
> Key: WW-3385
> URL: https://issues.apache.org/jira/browse/WW-3385
> Project: Struts 2
> Issue Type: Improvement
> Components: Dispatch Filter
> Affects Versions: 2.1.8.1
> Reporter: Erling Molde
> Assignee: Lukasz Lenart
> Priority: Trivial
>
> Noticed that the Map-wrapper classes
> (org.apache.struts2.dispatcher.RequestMap etc.) returns the new value from
> put-method.
> request.setAttribute(key.toString(), value);
> return get(key);
> Should be:
> V value = get(key);
> request.setAttribute(key.toString(), value);
> return value;
> in order to be consistent with other Map-implementations.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
