[ 
https://issues.apache.org/jira/browse/WW-3488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907660#action_12907660
 ] 

Maurizio Cucchiara commented on WW-3488:
----------------------------------------

Hi Lukasz,
I think that Rajeev is right. Furthermore, if you apply this patch you have to 
reopen this one https://issues.apache.org/jira/browse/WW-2869
What I meant to say two weeks ago is that  everytime root.size is greater then 
1 return always true inside shouldCopyStack method.
There is no other way. If you take a look at DefaultActionInvocation 
implementation, the invoke method first "chains" interceptor's invocation and 
after creates and executes result.
So, invocation.getResult yields always null  inside ChainInterceptor in my 
opinion (until  ActionChainResult use new instance of DefaultActionInvocation).

Why did not you consider a Chainable interface?
Otherwise, you might consider passing information between ActionChainResult and 
ChainingInterceptor through the ApplicationContext (I suppose CHAIN_HISTORY 
parameter).

> ChainingInterceptor doesn't copy the value stack to the target action
> ---------------------------------------------------------------------
>
>                 Key: WW-3488
>                 URL: https://issues.apache.org/jira/browse/WW-3488
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.2.1
>            Reporter: Mika Laukka
>            Assignee: Lukasz Lenart
>             Fix For: 2.2.2
>
>         Attachments: WW-3488.patch
>
>
> This can be easily reproduced by running the bundled struts2-showcase web 
> application.
> http://localhost:8080/struts2-showcase-2.2.1/actionchaining/actionChain1!input.action
> results in this:
> Action Chain 1 Property 1:
> Action Chain 2 Property 1:
> Action Chain 3 Property 1: Property set in Action Chain 3
> So clearly the properties set in action 1 and action 2 are lost in the 
> chaining process.
> For comparison, version 2.0.14 output
> http://localhost:8080/struts2-showcase-2.0.14/actionchaining/actionChain1!input.action
> results in this:
> Action Chain 1 Property 1:  Property Set In Action Chain 1
> Action Chain 2 Property 1: Property Set in Action Chain 2
> Action Chain 3 Property 1: Property set in Action Chain 3 
> Which is the expected result. This bug may be related to fixing of WW-2869.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to