[ 
https://issues.apache.org/jira/browse/WW-3546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12972152#action_12972152
 ] 

John Lindal commented on WW-3546:
---------------------------------

I don't think Struts should implement the method for setting the flag.  The 
signed cookie that I'm using is actually generated by a corp-wide login 
service.  I just use a corp library to check that it's valid.

I was only suggesting that Struts could provide the flag, so if it is set, it 
modifies (some uses of) devMode for that request.

> Add ability to control devMode per request
> ------------------------------------------
>
>                 Key: WW-3546
>                 URL: https://issues.apache.org/jira/browse/WW-3546
>             Project: Struts 2
>          Issue Type: New Feature
>          Components: Core Interceptors, Dispatch Filter, Plugin - JSON
>    Affects Versions: 2.2.1
>            Reporter: John Lindal
>            Priority: Minor
>
> I have found it useful to be able to control "debugging mode" on a 
> per-request basis.  It makes it easier to track down problems reported in 
> production that are hard to reproduce in a development environment.
> The places that I have found where it would be useful to control devMode are: 
>  Dispatcher.sendError(), JSONInterceptor, and DebuggingInterceptor.  (Other 
> uses of devMode are related to logging and config reloading, and that 
> shouldn't be adjustable.)
> I've currently patched my copy of Struts 2.2.1 so each of the the 
> above-mentioned code chunks checks an extra, static ThreadLocal variable that 
> I added (in addition to the devMode member variable).
> 1)  Is this the best solution?
> 2)  Is this something that should be merged into the Struts 2 distribution?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to