[ 
https://issues.apache.org/jira/browse/WW-3918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13491481#comment-13491481
 ] 

Hudson commented on WW-3918:
----------------------------

Integrated in Struts2 #557 (See [https://builds.apache.org/job/Struts2/557/])
    WW-3918 removes FileManager#isReloadConfigs() method and use 
@Inject("struts.configuration.xml.reload") (Revision 1406145)

     Result = UNSTABLE
lukaszlenart : 
Files : 
* 
/struts/struts2/trunk/core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java
* 
/struts/struts2/trunk/core/src/test/java/org/apache/struts2/dispatcher/DispatcherTest.java
* 
/struts/struts2/trunk/plugins/oval/src/main/java/org/apache/struts2/oval/interceptor/DefaultOValValidationManager.java
* 
/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/FileManager.java
* 
/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/config/ConfigurationManager.java
* 
/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/conversion/impl/XWorkConverter.java
* 
/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/util/fs/DefaultFileManager.java
* 
/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java
* 
/struts/struts2/trunk/xwork-core/src/main/java/com/opensymphony/xwork2/validator/DefaultActionValidatorManager.java
* 
/struts/struts2/trunk/xwork-core/src/test/java/com/opensymphony/xwork2/util/DefaultFileManagerTest.java
* 
/struts/struts2/trunk/xwork-core/src/test/java/com/opensymphony/xwork2/util/fs/DefaultFileManagerFactoryTest.java

                
> Instead checking FileManager#isReloadingConfigs() class should base on 
> @Inject("struts.configuration.xml.reload")
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: WW-3918
>                 URL: https://issues.apache.org/jira/browse/WW-3918
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.3.4.1
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.3.8
>
>
> It's unneeded dependency when class must check if config reloading is 
> enabled, it can simply check mentioned constant. Classes:
> - ConfigurationManager
> - XWorkConverter
> - AnnotationActionValidatorManager
> - DefaultActionValidatorManager
> - DefaultOValValidationManager

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to