[
https://issues.apache.org/jira/browse/WW-4125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707886#comment-13707886
]
Hudson commented on WW-4125:
----------------------------
SUCCESS: Integrated in Struts2-JDK6 #749 (See
[https://builds.apache.org/job/Struts2-JDK6/749/])
WW-4125 Improves loop and minor changes (lukaszlenart: rev 1502443)
*
/struts/struts2/trunk/plugins/struts1/src/main/java/org/apache/struts2/s1/Struts1Factory.java
> Wasted work in Struts1Factory.convertErrors()
> ---------------------------------------------
>
> Key: WW-4125
> URL: https://issues.apache.org/jira/browse/WW-4125
> Project: Struts 2
> Issue Type: Bug
> Affects Versions: 2.3.14.3
> Environment: any
> Reporter: Adrian Nistor
> Assignee: Lukasz Lenart
> Labels: patch, performance
> Fix For: 2.3.16
>
> Attachments: patch.diff
>
>
> The problem appears in version 2.3.14.3 and in revision 1495522. I
> attached a simple patch that fixes it. This problem and the attached
> patch are similar to the previously fixed WW-4116 and its patch.
> In method "Struts1Factory.convertErrors", the loop over "errors"
> should only be executed when "text != null" or "vaction != null" are
> "true", because the loop has no side effects when "text != null" and
> "vaction != null" are both "false". Note that "text" and "vaction"
> are not modified inside the loop.
> The patch just adds one line, the check:
> {code:java|borderStyle=solid}
> if (text != null || vaction != null) {
> {code}
> The patch looks large because the entire loop is indented one level,
> but the above check is the only code added.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
