[ 
https://issues.apache.org/jira/browse/WW-4275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13867729#comment-13867729
 ] 

ASF subversion and git services commented on WW-4275:
-----------------------------------------------------

Commit 1557084 from [~ghuber] in branch 'struts2/trunk'
[ https://svn.apache.org/r1557084 ]

Fix class cast exception.  See WW-4275.

> Cast exception on Supressing empty parameters on <s:a> tag 
> -----------------------------------------------------------
>
>                 Key: WW-4275
>                 URL: https://issues.apache.org/jira/browse/WW-4275
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Java Templates
>    Affects Versions: 2.3.16
>         Environment: Tomcat/Centos
>            Reporter: Greg Huber
>            Assignee: Greg Huber
>            Priority: Minor
>             Fix For: 2.3.17
>
>
> I have noticed that my patch does not handle integers correctly, alas, we 
> need to do another change
> It does kind of the same check, but this works with integers/doubles.
> {code:java}
> Object value = findValue(this.value);
> if (suppressEmptyParameters) {
> if (value != null && !value.toString().isEmpty()){ 
>   component.addParameter(name, value); }
> } else{
>   component.addParameter(name, value); 
> }
> {code}
> existing code:
> {code:java}
> if (suppressEmptyParameters) {
> String potentialValue = (String) value;
> if (potentialValue != null && potentialValue.length() > 0) { 
> component.addParameter(name, value); }
> } else { component.addParameter(name, value); }
> {code}



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to