[jira] [Commented] (WW-4354) ParametersInterceptor's isWithinLengthLimit() method ignores devMode

[Lukasz Lenart (JIRA)]

    [ 
https://issues.apache.org/jira/browse/WW-4354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14011039#comment-14011039
 ] 

Lukasz Lenart commented on WW-4354:
-----------------------------------

but {{notifyDeveloper}} respects see:

{code:java}
    private void notifyDeveloper(String message, String... parameters) {
        if (devMode) {
            LOG.warn(message, parameters);
        } else {
            if (LOG.isDebugEnabled()) {
                LOG.debug(message, parameters);
            }
        }
    }
{code}

> ParametersInterceptor's isWithinLengthLimit() method ignores devMode
> --------------------------------------------------------------------
>
>                 Key: WW-4354
>                 URL: https://issues.apache.org/jira/browse/WW-4354
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors
>    Affects Versions: 2.3.16.3
>            Reporter: Andreas Wolf
>             Fix For: 2.3.18
>
>
> In the Class com.opensymphony.xwork2.interceptor.ParametersInterceptor
> the method isWithinLengthLimit( String name ) does not consider the *devMode* 
> flag.
> {code}
> protected boolean isWithinLengthLimit( String name ) {
>         boolean matchLength = name.length() <= paramNameMaxLength;
>         if (!matchLength) {
>             notifyDeveloper("Parameter [#0] is too long, allowed length is 
> [#1]", name, String.valueOf(paramNameMaxLength));
>         }
>         return matchLength;
>       }
> {code}
> As a result, an ERROR is logged when a Paramter is too long.
> E.g.
> [com.opensymphony.xwork2.interceptor.ParametersInterceptor] [Developer 
> Notification (set struts.devMode to false to disable this message):
> Unexpected Exception caught setting '****' on 'class java.lang.String: 100]



--
This message was sent by Atlassian JIRA
(v6.2#6252)