Brent N Atkinson created WW-4452:
------------------------------------

             Summary: s:optiontransferselect javascript functions no longer 
work with negative integer keys
                 Key: WW-4452
                 URL: https://issues.apache.org/jira/browse/WW-4452
             Project: Struts 2
          Issue Type: Bug
    Affects Versions: 2.3.20
            Reporter: Brent N Atkinson


It appears that the change made to fix WW-4365 broke the javascript functions 
used to implement onclick handlers for the s:optiontransferselect tag. 

While attempting an upgrade to 2.3.20 from 2.3.16.3, all pages containing tags 
like the following are broken (tests fail):

{code}
<s:optiontransferselect multiple="true" headerKey="-1" doubleHeaderKey="-1" 
multiple="true" doubleMultiple="true" 
addAllToRightOnclick="selectAllOptionsExceptSome(document.getElementById('saveBuildDefinitionTemplate_selectedBuildDefinitionIds'),
 'key', '-1');" />
{code}

Since the regular expression used to match the header keys now always attempts 
to match on word boundary, the change introduced in WW-4365, it will not match 
negative numbers like '-1'. This is likely to break a number of applications 
since [the struts 2 documentation for 
optiontransferselect|https://cwiki.apache.org/confluence/display/WW/optiontransferselect]
 suggests using '-1'.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to