[
https://issues.apache.org/jira/browse/WW-4514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14583383#comment-14583383
]
Jasper Rosenberg edited comment on WW-4514 at 6/12/15 1:34 PM:
---------------------------------------------------------------
Patch with suggested fix. Also includes updates to unit test to test empty and
non-empty list parameters.
was (Author: perfnorm):
Patch with suggested fix.
> DefaultUrlHelper.buildParametersString appends just ? if collection is empty
> ----------------------------------------------------------------------------
>
> Key: WW-4514
> URL: https://issues.apache.org/jira/browse/WW-4514
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.3.24
> Reporter: Jasper Rosenberg
> Priority: Trivial
> Attachments: DefaultUrlHelper.patch
>
>
> DefaultUrlHelper.buildParametersString() checks that it has parameters to
> append before adding the first "?"/"&", but if the only parameters are empty
> Iterables/Arrays, then it shouldn't do that.
> I'd suggest adding the new query string to a StringBuilder, and then if it is
> non-empty, append that with the separator to the link at the end. (See patch)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
