[
https://issues.apache.org/jira/browse/WW-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14963932#comment-14963932
]
Hudson commented on WW-4536:
----------------------------
SUCCESS: Integrated in Struts-JDK7-master #378 (See
[https://builds.apache.org/job/Struts-JDK7-master/378/])
WW-4536 Drops static to allow redefine the key (lukaszlenart: rev
5dcbe657b015c6df5ebbdf35e2548cef41099116)
*
core/src/test/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManagerTest.java
*
core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java
WW-4536 Checks for patterns in action names to build the same key for
(lukaszlenart: rev b79c6959a4d5fbfd816e6dce660b095683ad987b)
*
core/src/main/java/com/opensymphony/xwork2/validator/AnnotationActionValidatorManager.java
> potential memory leak with annotationActionValidatorManager
> -----------------------------------------------------------
>
> Key: WW-4536
> URL: https://issues.apache.org/jira/browse/WW-4536
> Project: Struts 2
> Issue Type: Bug
> Components: XML Validators
> Affects Versions: 2.3.20
> Reporter: adam brin
> Assignee: Lukasz Lenart
> Fix For: 2.3.25, 2.5
>
> Attachments: Screen Shot 2015-08-16 at 1.48.30 PM.png, Screen Shot
> 2015-08-16 at 1.49.22 PM.png
>
>
> We've recently been having issues with our app crashing and trying to track
> down the root causes. One of the things we've seen is that over the course
> of 1 day, 50% of our memory (almost 620 MB of 1.2 GB) is allocated to
> "com.opensymphony.xwork.validator.AnnotationActionValidatorManager" according
> to the heap dump. We also see millions of entries in two SynchronizedMap's:
> * validatorCache (1,635,019 entries)
> * validatorFileCache (87,321 entries)
> Looking through the entries in the validator cache, we se entries for every
> unique page browsed within the app. Note: we're using staticParam mapping and
> NamedVariable PatternMatching in action names e.g. {{"$\{id\}/$\{slug\}"}} so
> effectively every url is unique.
> Looking at the source code, should these maps perhaps be "WeakHashMaps" or
> WeakReferences so that they're disposed of?
> (source code to the app is here: https://bitbucket.org/tdar/tdar.src/src )
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
