[
https://issues.apache.org/jira/browse/WW-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106680#comment-15106680
]
ASF GitHub Bot commented on WW-4412:
------------------------------------
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/79#discussion_r50108754
--- Diff:
plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java ---
@@ -110,7 +110,9 @@ public void doExecute(String location, ActionInvocation
invocation) throws Excep
HttpServletResponse httpResponse =
ServletActionContext.getResponse();
Request request = new ServletRequest(applicationContext,
httpRequest, httpResponse);
-
+
+ container.startContext(request);
container.render(location, request);
+ container.endContext(request);
--- End diff --
This isn't needed, `container.render` starts and ends context.
> Context started without being closed
> ------------------------------------
>
> Key: WW-4412
> URL: https://issues.apache.org/jira/browse/WW-4412
> Project: Struts 2
> Issue Type: Bug
> Components: Plugin - Tiles
> Affects Versions: 2.3.16.3
> Reporter: Hazem Taji
> Fix For: 2.5
>
> Attachments: tiles-test.zip
>
>
> In the TilesResult class, in doExecute, a context is started but not ended.
> This causes the context stack later to have extra irrelevant contexts.
> The problem prevents the use of <s:action> tags where actions have tile
> results and results in the tile attributes being unrecognized.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
