[ 
https://issues.apache.org/jira/browse/WW-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107403#comment-15107403
 ] 

ASF GitHub Bot commented on WW-4590:
------------------------------------

Github user aleksandr-m commented on the pull request:

    https://github.com/apache/struts/pull/75#issuecomment-172982203
  
    @swiftelan So you are proposing to change only type? The name of the 
attribute will stay the same i.e `name`, right? There is still some chance that 
something going to break, note that `ResultInfo` depends on `Result`'s `name`. 
But it is better than changing the name.
    
    @lukaszlenart WDYT about changing `Result`'s `name` to `String[] name() 
default com.opensymphony.xwork2.Action.SUCCESS;` and probably removing `public 
ResultInfo(Result, PackageConfig, String, Class<?>, Map<String, 
ResultTypeConfig>)` constructor?


> Allow to use multiple names in result
> -------------------------------------
>
>                 Key: WW-4590
>                 URL: https://issues.apache.org/jira/browse/WW-4590
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - Convention, XML Configuration
>    Affects Versions: 2.3.24
>            Reporter: Aleksandr Mashchenko
>            Assignee: Aleksandr Mashchenko
>             Fix For: 2.5
>
>
> Allow to use multiple values in {{result}} tag {{name}} attribute and in 
> {{Result}} annotation {{name}}.
> So this typical configuration:
> {code:xml}
> <action name="save">
>     <result>success.jsp</result>
>     <result name="error">input-form.jsp</result>
>     <result name="input">input-form.jsp</result>
> </action>
> {code}
> Can be shorten to that:
> {code:xml}
> <action name="save">
>     <result>success.jsp</result>
>     <result name="error, input">input-form.jsp</result>
> </action>
> {code}
> And this annotations:
> {code:java}
> @Action(results = {
>     @Result(name="error", location="input-form.jsp"),
>     @Result(name="input", location="input-form.jsp"),
>     @Result(name="success", location="success.jsp")
> })
> {code}
> To that:
> {code:java}
> @Action(results = {
>     @Result(name="error, input", location="input-form.jsp"),
>     @Result(name="success", location="success.jsp")
> })
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to