[
https://issues.apache.org/jira/browse/WW-4594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123746#comment-15123746
]
ASF GitHub Bot commented on WW-4594:
------------------------------------
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/85#discussion_r51284673
--- Diff:
apps/showcase/src/main/java/org/apache/struts2/showcase/tiles/TilesAnnotationsAction.java
---
@@ -0,0 +1,21 @@
+package org.apache.struts2.showcase.tiles;
+
+import org.apache.struts2.convention.annotation.Namespace;
+import org.apache.struts2.convention.annotation.ParentPackage;
+import org.apache.struts2.convention.annotation.Result;
+import org.apache.struts2.tiles.annotation.TilesDefinition;
+import org.apache.struts2.tiles.annotation.TilesPutAttribute;
+
+import com.opensymphony.xwork2.ActionSupport;
+
+@Namespace("/tiles")
+@ParentPackage("tiles")
+@Result(name = "success", type="tiles")
+@TilesDefinition(extend = "showcase.annotations", putAttributes = {
+ @TilesPutAttribute(name = "header", value =
"/WEB-INF/tiles/header.jsp"),
+ @TilesPutAttribute(name = "body", value =
"/WEB-INF/tiles/body.ftl"), })
--- End diff --
I think the last comma isn't needed and also what do you think about
formatting like this:
```java
@Namespace("/tiles")
@ParentPackage("tiles")
@Result(name = "success", type="tiles")
@TilesDefinition(extend = "showcase.annotations", putAttributes = {
@TilesPutAttribute(name = "header", value =
"/WEB-INF/tiles/header.jsp"),
@TilesPutAttribute(name = "body", value = "/WEB-INF/tiles/body.ftl")
})
```
?
> Configure TilesDefs by annotating Actions
> -----------------------------------------
>
> Key: WW-4594
> URL: https://issues.apache.org/jira/browse/WW-4594
> Project: Struts 2
> Issue Type: New Feature
> Components: Plugin - Tiles
> Reporter: Christoph Nenning
> Assignee: Christoph Nenning
> Fix For: 2.5
>
>
> Large applications often consist of hundrets of actions. IMO it is a major
> benefit of struts-convention-plugin that it is not necessary to configure all
> those actions in xml files. As xml files would become huge and hard to
> maintain. The same applies to tiles xml files. Currently it is necessary to
> configure tiles-definitions for all those actions in xml files which makes
> them huge and hard to maintain.
> It would be great if configuration of tiles-definitions could be done by
> annotating actions, in a similar way actions can be configured with
> annotations from convention-plugin.
> This somewhat relates to WW-3937 and WW-4161
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
