[
https://issues.apache.org/jira/browse/WW-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15132116#comment-15132116
]
Lukasz Lenart edited comment on WW-4596 at 2/4/16 1:12 PM:
-----------------------------------------------------------
Missed the {{allowedMethods = new HashSet<>();}} also ;)
#####
I tried :
{code:xml}
<action name="myView!*" method="prefix{0}suffix"
class="ui.struts2.editor.MyView">
{code}
which needed a method in MyView for it to work
{code:java}
public String prefixmyViewsuffix() {
execute();
return "input";
}
{code}
Stripping out \{0\} and {{prefix\{0}suffix}} did not seem to make a difference,
it stlll envoked the {{prefixmyViewsuffix()}} method but failed the SMI (ie was
not blocked).
Leaving {{prefix\{0}suffix}} in also made no difference, and failed the SMI (ie
was not blocked).
{noformat}
PatternAllowedMethod{allowedMethodPattern=prefix(.*)suffix,
original='prefix{0}suffix'},
{noformat}
Would have though removing {{prefix\{0}suffix}} would break the ActionConfig,
maybe its getting the method name {{prefixmyViewsuffix()}} from somewhere else?
was (Author: gregh99):
Missed the allowedMethods = new HashSet<>(); also ;)
#####
I tried :
<action name="myView!*" method="prefix{0}suffix"
class="ui.struts2.editor.MyView">
which needed a method in MyView for it to work
{code:java}
public String prefixmyViewsuffix() {
execute();
return "input";
}
{code}
Stripping out {0} and prefix{0}suffix did not seem to make a difference, it
stlll envoked the prefixmyViewsuffix() method but failed the SMI (ie was not
blocked).
Leaving prefix{0}suffix in also made no difference, and failed the SMI (ie was
not blocked).
PatternAllowedMethod{allowedMethodPattern=prefix(.*)suffix,
original='prefix{0}suffix'},
Would have though removing prefix{0}suffix would break the ActionConfig, maybe
its getting the method name prefixmyViewsuffix() from somewhere else?
> Strict DMI causes This method: for action is not allowed!
> -----------------------------------------------------------
>
> Key: WW-4596
> URL: https://issues.apache.org/jira/browse/WW-4596
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions
> Affects Versions: 2.5
> Reporter: Greg Huber
> Fix For: 2.5
>
>
> I have tried adding
> {code:xml}
> <global-allowed-methods>execute,input,cancel</global-allowed-methods>
> {code}
> and get
> {noformat}
> This method: cancel for action eventAdd is not allowed! - [unknown location]
> {noformat}
> {code:xml}
> <action name="eventAdd!*" method="{1}"
> class="ui.struts2.editor.EventAdd">
> <result name="input" type="tiles">.EventAdd</result>
> <result name="success" type="chain">eventEdit</result>
> <result name="cancel" type="redirectAction">
> <param name="actionName">memberEvents</param>
> <param name="pgn">${bean.pageNum}</param>
> <param name="suppressEmptyParameters">true</param>
> </result>
> </action>
> {code}
> checking ActionConfig:
> {code:java}
> public boolean isAllowedMethod(String method) {
> return method.equals(methodName != null ? methodName :
> DEFAULT_METHOD) || allowedMethods.isAllowed(method);
> }
> {code}
> Debugging I get a calls to isAllowedMethod with :
> {noformat}
> 1 methodName = {1} and method = execute
> 2 methodName = execute and method = cancel
> {noformat}
> Only #1 has the required cancel
> #2 there is only a {{\[LiteralAllowedMethod\{allowedMethod='execute'\}\]}}
> On further investigation
> {{com.opensymphony.xwork2.config.implActionConfigMatcher}} seems to create a
> new ActionConfig but then only uses the default allowed names:
> {code:java}
> return new ActionConfig.Builder(pkgName, orig.getName(), className)
> .methodName(methodName)
> .addParams(params)
> .addResultConfigs(results)
> .addInterceptors(orig.getInterceptors())
> .addExceptionMappings(exs)
> .location(orig.getLocation())
> .build();
> {code}
> Could use the original by appending
> .addAllowedMethod(orig.getAllowedMethods()), but I guess it should come from
> the ActionConfig stored in the packageContext or wherever the orig object
> gets its allowedMethods from.
> Cheers Greg
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
