[
https://issues.apache.org/jira/browse/WW-4572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15212082#comment-15212082
]
ASF GitHub Bot commented on WW-4572:
------------------------------------
GitHub user lukaszlenart reopened a pull request:
https://github.com/apache/struts/pull/58
Http parameters
Implements WW-4572
This PR converts `parameters` to be represented by a dedicated class -
`HttpParameters` - instead of using a simple `Map`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukaszlenart/struts http-parameters
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/58.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #58
----
commit 6b20fb51ba18d82e06b791094aa52fe135e4825a
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T07:29:11Z
Introduces new class to represent HTTP parameters
commit 787f2f96eb9f1bb3c8012ab42aa222ae6286a91a
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T07:30:03Z
Introduces new class to represent expression evaluation
commit 330a0edf264328e01792ffd911957aa3547a0ae0
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T07:30:23Z
Uses the class instead of a Map
commit 5508352ddb46417ccd44033064ea337da509c021
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T07:32:10Z
Uses HttpParameters class instead of a generic Map
commit 6ad4f9f0184fa1aaf411742c4e753bb3aa66394c
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T09:14:27Z
Updates implementation and fixes test
commit 26235599cd6fc5f9519c268cc6861d52a0d99652
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:04:40Z
Fixes issue with filtering out excluded params
commit 8282d60fa53b6df3fd68704cbdb25192650fd4a2
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:09:28Z
Adjusts test
commit fe1cbc453af86cddf89b9c792f0b6814f4549243
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:12:17Z
Updates test
commit c393a428bee66ef7c8b12320a3d69251263d10c1
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:27:55Z
Fixes test and cleans up naming
commit 2c110e2a461dc2acfeede416df0182940d3c3b49
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:29:46Z
Fixes test
commit fcd407cb451253980977b21f1c05120596d6d469
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:30:32Z
Fixes test
commit b0a2fbcc077664db6b788aacbad3538429c6f972
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:32:41Z
Fixes test
commit 560f03025f142fa4bbcf0a5bc83c5b798d9c9229
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:33:25Z
Fixes test
commit b373d6a43a9d40e4802eea721fe792af3ec59d40
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:33:59Z
Fixes test
commit 1fa8eac8bd3d36a32bc582e3ca9a79d184f3efe3
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:34:30Z
Fixes test
commit 4b8f7b06802c9328eb18c5e0da4e9682416744f9
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:35:01Z
Fixes test
commit 6fd94e86617aafe08afcad487b9179b03a629ec4
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:36:44Z
Fixes test
commit bda06c8baa2f65b6e340a7a8bc24a635a865bbcd
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:38:02Z
Fixes test
commit 8dc6f77e0ba22ee9f7667488e4051aa40d0a0642
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T12:52:33Z
Creates ActionMapping with empty params
commit bb115bef81cda211e07c7ce77a5187fe112c3f3e
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T13:39:22Z
Fixes support for checkboxes
commit 48602b899d03d953782244858dc8c521b8287b73
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T18:40:29Z
Fixes test
commit c14791a2a05072626462f62518bf28d468b3af46
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T18:49:14Z
Fixes test
commit 582bb32e4bc982830bd75d3a125c635c48db2d85
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T18:56:19Z
Adjusts interceptor
commit 9640c2b3a14ad1c0426cdcb4c469672eba6bc414
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T19:10:19Z
Fixes test
commit bb096d6415c4750c5a08aa35605e789e880a9a14
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-05T19:11:27Z
Fixes test
commit 3a0bd4caf047dfe2918bc4527ffa41f2342b947e
Author: Lukasz Lenart <[email protected]>
Date: 2015-10-06T06:02:30Z
Updates tests
commit ce8ac8e3ce0070bd1a73c1202719e26e48800523
Author: Lukasz Lenart <[email protected]>
Date: 2015-11-25T18:02:54Z
Introduces getObject getter to keep compatibility
commit 60b9d85d44826f7421ddaaa5870a7818e7f5fb41
Author: Lukasz Lenart <[email protected]>
Date: 2015-11-25T18:03:30Z
Adjusts usage of parameters
commit 059ebc72c2e58bb96e586bda797e55ed43a806c9
Author: Lukasz Lenart <[email protected]>
Date: 2015-11-25T18:03:36Z
Updates tests
commit 278b22a0b4661f67d461675c3ac51d55856fb9b5
Author: Lukasz Lenart <[email protected]>
Date: 2015-12-19T11:07:22Z
Renames method to better express its meaning
----
> Add dedicated class to represent Http Parameters
> ------------------------------------------------
>
> Key: WW-4572
> URL: https://issues.apache.org/jira/browse/WW-4572
> Project: Struts 2
> Issue Type: Improvement
> Components: "New" API
> Affects Versions: 2.3.24
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Fix For: 2.5
>
>
> Right now {{parameters}} are represented by a {{Map}} and a lot of logic is
> duplicated. There is no way to check if given parameter was already evaluated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
