[
https://issues.apache.org/jira/browse/WW-4646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420761#comment-15420761
]
Sebastian Götz edited comment on WW-4646 at 8/15/16 9:21 AM:
-------------------------------------------------------------
Sure. I did explicitly exclude asm AND asm-commons via IVY exclude and then
added asm AND asm-commons 5.1. I even investigated the success with the Eclipse
Reverse Dependency Explorer (tool to visualize dependency hierarchy) AND did
check the webapps deployment folder for libraries.
EDIT:
I had a look at the downloaded struts-convention-plugin.jar (2.5.2) and checked
the file META-INF/DEPENDENCIES. There asm 3.3 is listed:
{noformat}
From: 'ObjectWeb' (http://www.objectweb.org/)
- ASM Core (http://asm.objectweb.org/asm/) asm:asm:jar:3.3
License: BSD (http://asm.objectweb.org/license.html)
- ASM Commons (http://asm.objectweb.org/asm-commons/) asm:asm-commons:jar:3.3
License: BSD (http://asm.objectweb.org/license.html)
- ASM Tree (http://asm.objectweb.org/asm-tree/) asm:asm-tree:jar:3.3
License: BSD (http://asm.objectweb.org/license.html)
{noformat}
was (Author: s.goetz):
Sure. I did explicitly exclude asm AND asm-commons via IVY exclude and then
added asm AND asm-commons 5.1. I even investigated the success with the Eclipse
Reverse Dependency Explorer (tool to visualize dependency hierarchy) AND did
check the webapps deployment folder for libraries.
> remove ASM 3 from struts2
> -------------------------
>
> Key: WW-4646
> URL: https://issues.apache.org/jira/browse/WW-4646
> Project: Struts 2
> Issue Type: Bug
> Components: Core Actions, Plugin - Convention
> Affects Versions: 2.5
> Reporter: adam brin
> Assignee: Lukasz Lenart
> Fix For: 2.5.3
>
>
> Pulling from the discussion on the struts2-users list:
> Struts2 maintains two different versions of ASM 5x for the Convention plugin
> and 3x for the rest of struts. A basic search of the codebase suggests that
> the only direct uses of ASM are via the ClassFinder class in Xwork and used
> by the Convention plugin. Based on this
> [https://issues.apache.org/jira/browse/WW-4435] and
> [http://www.philvarner.com/2015/02/05/using-apache-cxf-2-7-struts2-2-3-and-asm-5-with-maven/],
> I wonder if it might make sense to:
> 1. remove the direct dependency on ASM entirely for XWork and Struts2 in
> general
> 2. move the ClassFinder class and direct dependencies the convention plugin
> and make them explicitly dependent on ASM 5x.
> 3. Like other apps like Spring, repackage/embed ASM into it's own package
> tree so it can live with other versions of ASM.
> -----
> the core issue for us is that there are overlaps between ASM 5 and ASM 3, and
> become explicit when launching our app with the maven-jetty-plugin. Classes
> with the same name in both packages though they have different groupIds and
> thus cause exceptions in startup either due to (a) Missing Classes like
> EmptyVisitor or (b) incompatible classes. It's our hope that by removing this
> dual dependency, we can take advantage of Java8 features and also simplify
> dependency management in our pom.
> thanks
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
