[ 
https://issues.apache.org/jira/browse/WW-4722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15712865#comment-15712865
 ] 

Hudson commented on WW-4722:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-JDK7-master #567 (See 
[https://builds.apache.org/job/Struts-JDK7-master/567/])
WW-4722 Renames constant for better readability (lukaszlenart: rev 
bcea4c9bafb101901543c97174fb3d20d0f0c017)
* (edit) 
core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
WW-4722 Allows predefine default store location (lukaszlenart: rev 
6e1ea61dc664c4a4e41a8a094030f2edf0088f6c)
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
WW-4722 Refactors code to use predefined storage locatio (lukaszlenart: rev 
6457f002d97cde76f98444ec98abdb9bc4be191f)
* (edit) 
core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
WW-4722 Extracts logic to store locale in cookie into a method (lukaszlenart: 
rev 8971b5081055bd309f715aad63fd96825154c3f8)
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
WW-4722 Reuses global fields and cleans up logging (lukaszlenart: rev 
fddc6582e0a66e82b045824fb214e43d7d6c36fd)
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
WW-4722 Prepares ActionProxy to be used with test (lukaszlenart: rev 
f515def5b82f29b2accac056e2148077047bdfd1)
* (edit) 
core/src/test/java/org/apache/struts2/interceptor/I18nInterceptorTest.java
WW-4722 Refactors store logic (lukaszlenart: rev 
aabc90df6b8293f597903ac2c9016270b4a37d52)
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java
WW-4722 Adds description of storage parameter (lukaszlenart: rev 
09958919caabc66d3b963b81af6f8c3c4b44efe0)
* (edit) core/src/main/java/org/apache/struts2/interceptor/I18nInterceptor.java


> Portlet Issue with I18Interceptor
> ---------------------------------
>
>                 Key: WW-4722
>                 URL: https://issues.apache.org/jira/browse/WW-4722
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Core Interceptors, Plugin - Portlet
>    Affects Versions: 2.5.5
>            Reporter: Todd Kofford
>            Assignee: Lukasz Lenart
>              Labels: interceptors, portlet
>             Fix For: 2.5.7
>
>
> Portlets always throw the following exception:
> {quote}
> java.lang.IllegalStateException: Not allowed in a portlet
> {quote}
> Below is the method in the classs
> *org.apache.struts2.portlet.servlet.PortletServletRequest* where this always
> happens:
> {code:java}
> public Cookie[] getCookies() {
>     if (portletRequest instanceof HttpServletRequest) {
>         return ((HttpServletRequest) portletRequest).getCookies();
>     }
>     throw new IllegalStateException("Not allowed in a portlet");
> }
> {code}
> Apparently, the "portletRequest" variable is not an instance of 
> "HttpServletRequest".
> *NOTE -* There are many other methods in class *PortletServletRequest* that 
> use the exact same assumption/logic as the "getCookies()" method.
> That class is invoked by the class
> *org.apache.struts2.interceptor.I18nInterceptor*, which was just changed in 
> version 2.5.5. See change [https://issues.apache.org/jira/browse/WW-4686]
> Finally, below is a partial stack trace
> {quote}
> SEVERE: Servlet.service() for servlet struts2portlet threw exception
> java.lang.IllegalStateException: Not allowed in a portlet
>       at
> org.apache.struts2.portlet.servlet.PortletServletRequest.getCookies(PortletServletRequest.java:101)
>       at
> org.apache.struts2.interceptor.I18nInterceptor.readStoredLocale(I18nInterceptor.java:215)
>       at
> org.apache.struts2.interceptor.I18nInterceptor.storeLocale(I18nInterceptor.java:189)
>       at
> org.apache.struts2.interceptor.I18nInterceptor.intercept(I18nInterceptor.java:144)
>       at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
>       at
> org.apache.struts2.interceptor.ServletConfigInterceptor.intercept(ServletConfigInterceptor.java:171)
>       at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
>       at
> com.opensymphony.xwork2.interceptor.AliasInterceptor.intercept(AliasInterceptor.java:195)
>       at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
>       at
> com.opensymphony.xwork2.interceptor.ExceptionMappingInterceptor.intercept(ExceptionMappingInterceptor.java:193)
>       at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
>       at
> org.apache.struts2.portlet.interceptor.PortletAwareInterceptor.intercept(PortletAwareInterceptor.java:81)
>       at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
>       at
> org.apache.struts2.portlet.interceptor.PortletStateInterceptor.intercept(PortletStateInterceptor.java:51)
>       at
> com.opensymphony.xwork2.DefaultActionInvocation.invoke(DefaultActionInvocation.java:240)
>       at
> org.apache.struts2.factory.StrutsActionProxy.execute(StrutsActionProxy.java:54)
>       at
> org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher.serviceAction(Jsr168Dispatcher.java:481)
>       at
> org.apache.struts2.portlet.dispatcher.Jsr168Dispatcher.render(Jsr168Dispatcher.java:341)
>       at
> org.jasig.portal.portlet.container.FilterChainImpl.doFilter(FilterChainImpl.java:183)
>       at
> org.jasig.portal.portlet.container.FilterChainImpl.processFilter(FilterChainImpl.java:99)
>       at
> org.jasig.portal.portlet.container.FilterManagerImpl.processFilter(FilterManagerImpl.java:110)
>       at
> org.apache.pluto.container.driver.PortletServlet.dispatch(PortletServlet.java:340)
>       at
> org.apache.pluto.container.driver.PortletServlet.doGet(PortletServlet.java:261)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:622)
>       at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to