[ 
https://issues.apache.org/jira/browse/WW-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15787687#comment-15787687
 ] 

Hudson commented on WW-4102:
----------------------------

SUCCESS: Integrated in Jenkins build Struts-JDK7-master #574 (See 
[https://builds.apache.org/job/Struts-JDK7-master/574/])
WW-4102 Reduces LOG visibility (lukaszlenart: rev 
3ce21403ee3df02aba11ae32c5e7ca54875ad220)
* (edit) core/src/main/java/com/opensymphony/xwork2/ActionSupport.java
* (edit) 
plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ListValidatorsAction.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/interceptor/ExceptionMappingInterceptor.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/interceptor/MethodFilterInterceptor.java
* (edit) 
plugins/config-browser/src/main/java/org/apache/struts2/config_browser/ShowJarsAction.java
* (edit) core/src/main/java/org/apache/struts2/interceptor/TokenInterceptor.java
* (edit) 
core/src/test/java/com/opensymphony/xwork2/interceptor/TimerInterceptorTest.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/interceptor/TimerInterceptor.java
* (edit) 
core/src/main/java/com/opensymphony/xwork2/validator/ValidationInterceptor.java


> ActionSupport.LOG should be private
> -----------------------------------
>
>                 Key: WW-4102
>                 URL: https://issues.apache.org/jira/browse/WW-4102
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Actions
>    Affects Versions: 2.3.14.3
>            Reporter: Marcin Kamionowski
>            Assignee: Lukasz Lenart
>             Fix For: 2.5.next
>
>
> ActionSupport is base class for actions. Actions cannot (or at least 
> shouldn't) use ActionSupport.LOG because localisation source of messages is 
> much harder in this situation. When ActionSuport.LOG is protected, some 
> programmers might accidentally use this instance (LOG is popular name for 
> loggers).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to