ASF GitHub Bot commented on WW-4827:

Github user lukaszlenart commented on the issue:

    The case is that on second container initialisation we do not create 
singletons upfront ... I have tried to change that but got some problems, not 
sure why. I must re-think how we initialise Struts internals ...

> Not fully initialized ObjectFactory tries to create beans
> ---------------------------------------------------------
>                 Key: WW-4827
>                 URL: https://issues.apache.org/jira/browse/WW-4827
>             Project: Struts 2
>          Issue Type: Bug
>    Affects Versions: 2.5.12
>            Reporter: Aleksandr Mashchenko
>            Assignee: Lukasz Lenart
>            Priority: Critical
>             Fix For: 2.5.13
> This leads to issues when properties aren't injected in some cases, for 
> example in custom type converters.
> The problem happens when {{ObjectFactory}} tries to create a bean in the same 
> time not being fully initialized itself (e.g. {{ConverterFactory}} injected 
> before {{Container}}).
> The issue happens more often under linux (all the time basically) than under 
> windows, so it cannot be reproduced 100%. This behavior boils down to the 
> fact that {{clazz.getDeclaredMethods()}} is used to get methods which needs 
> to be injected and {{clazz.getDeclaredMethods()}} returned elements are - 
> _The elements in the array returned are not sorted and are not in any 
> particular order._
> Proposed solution moves Container injection from method to constructor in 
> ObjectFactory -  
> https://github.com/aleksandr-m/struts/commit/6f91d0776a545c911ca4f2875ed9976614711ef9.
> The downside is it isn't backward-compatible, custom object factories must be 
> updated.

This message was sent by Atlassian JIRA

Reply via email to