[ 
https://issues.apache.org/jira/browse/WW-4858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Yasser Zamani updated WW-4858:
------------------------------
    Description: 
{{JSONInterceptor}} must populate value stack via OGNL to honor our exclusions!

So according to my current quick view and understanding, I'm planning something 
like below which also resolves WW-3364: {{JSONInterceptor}} could be an 
extension of {{ModelDrivenInterceptor}} via some refactoring of both. From 
hereafter, {{JSONPopulator}} could be removed and {{JSONInterceptor}} must give 
population up to {{ParametersInterceptor}}. This simply could be achieved by 
something like pushing {{JSONInterceptor.root}} into top of stack and also 
moving posted json to http params (or if was impossible some refactoring of 
{{ParametersInterceptor}}).

Please cast here any objections, votes or idea.

  was:
{{JSONInterceptor}} must populate value stack via OGNL to honor our exclusions!

So according to my current quick view and understanding, I'm planning something 
like below which also resolves WW-3364: {{JSONInterceptor}} could be an 
extension of {{ModelDrivenInterceptor}} via some refactoring of both. From 
hereafter, {{JSONPopulator}} could be removed and {{JSONInterceptor}} must give 
population up to {{ParametersInterceptor}}. This simply could be achieved by 
something like pushing {{JSONInterceptor.root}} into top of stack and also 
moving posted json to http params (or if was impossible some refactoring of 
{{ParametersInterceptor}}).

If you had any objections, votes or idea, please cast here as I'm going to 
start after merge of [#167|https://github.com/apache/struts/pull/167].


> JSONInterceptor must not populate value stack directly
> ------------------------------------------------------
>
>                 Key: WW-4858
>                 URL: https://issues.apache.org/jira/browse/WW-4858
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Plugin - JSON
>    Affects Versions: 2.3.x, 2.5.x
>            Reporter: Yasser Zamani
>              Labels: decouple, refactoring
>             Fix For: 2.3.35, 2.5.14
>
>
> {{JSONInterceptor}} must populate value stack via OGNL to honor our 
> exclusions!
> So according to my current quick view and understanding, I'm planning 
> something like below which also resolves WW-3364: {{JSONInterceptor}} could 
> be an extension of {{ModelDrivenInterceptor}} via some refactoring of both. 
> From hereafter, {{JSONPopulator}} could be removed and {{JSONInterceptor}} 
> must give population up to {{ParametersInterceptor}}. This simply could be 
> achieved by something like pushing {{JSONInterceptor.root}} into top of stack 
> and also moving posted json to http params (or if was impossible some 
> refactoring of {{ParametersInterceptor}}).
> Please cast here any objections, votes or idea.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to