[ https://issues.apache.org/jira/browse/WW-4996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735095#comment-16735095 ]
Hudson commented on WW-4996: ---------------------------- SUCCESS: Integrated in Jenkins build Struts-master-JDK7 #248 (See [https://builds.apache.org/job/Struts-master-JDK7/248/]) WW-4996 Refactors creator to use ObjectFactory#buildConverter method (lukaszlenart: rev 243a8c832b9fc3b3628ef9302085c9ec128fd0fc) * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (delete) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverterCreator.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/main/resources/struts-default.xml * (add) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterCreator.java WW-4996 Renames and moves class to proper package to better expose its (lukaszlenart: rev 6adfbed282d50318290de9414c9fed8bd2cd3775) * (add) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterHolder.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (delete) core/src/main/java/com/opensymphony/xwork2/conversion/impl/DefaultTypeConverterHolder.java * (edit) core/src/main/resources/struts-default.xml * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (edit) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterCreator.java * (edit) core/src/main/java/com/opensymphony/xwork2/factory/DefaultConverterFactory.java WW-4996 Reduces code duplication (lukaszlenart: rev c941326bf3da458beabcaab81456e51951318bcf) * (edit) core/src/main/java/org/apache/struts2/conversion/StrutsTypeConverterCreator.java WW-4996 Uses Struts* naming pattern instead of Default* (lukaszlenart: rev 19134516d8ef338c28c08dde60a7fb413be0357c) * (edit) core/src/main/resources/struts-default.xml * (edit) core/src/main/java/com/opensymphony/xwork2/config/providers/XWorkConfigurationProvider.java * (delete) core/src/main/java/com/opensymphony/xwork2/factory/DefaultConverterFactory.java * (edit) core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java * (add) core/src/main/java/com/opensymphony/xwork2/factory/StrutsConverterFactory.java WW-4996 Fixes post rebase file name changes (lukaszlenart: rev a4bfb0d0f2108e087dadf96a20a1d1387e8c86a5) * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-allowstatic-devmode-true.xml * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-devmode-true.xml * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-allowstatic-devmode-false.xml * (edit) core/src/test/resources/com/opensymphony/xwork2/config/providers/xwork-test-allowstatic-true.xml > Refactor DefaultTypeConverterCreator to use ObjectFactory#buildConverter > ------------------------------------------------------------------------ > > Key: WW-4996 > URL: https://issues.apache.org/jira/browse/WW-4996 > Project: Struts 2 > Issue Type: Improvement > Components: Core > Reporter: Lukasz Lenart > Assignee: Lukasz Lenart > Priority: Minor > Fix For: 2.6 > > > Right now {{DefaultTypeConverterCreator}} doesn't use > {{ObjectFactory#buildConverter()}} method which is a bit misleading. Also the > class name is misleading as this is a default Struts implementation so it > should be named {{StrutsTypeConverterCreator}}. -- This message was sent by Atlassian JIRA (v7.6.3#76005)