[
https://issues.apache.org/jira/browse/WW-5022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955218#comment-16955218
]
Hudson commented on WW-5022:
----------------------------
SUCCESS: Integrated in Jenkins build Struts-master-JDK8 #268 (See
[https://builds.apache.org/job/Struts-master-JDK8/268/])
Proposed fix for WW-5022 (escape html tag body control flag) - Added
(43964333+jcgh4164838gh792c124b5: rev 9592355960850108af0097c44ac49600cc062734)
* (edit) apps/showcase/src/main/webapp/WEB-INF/decorators/main.jsp
* (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/SubmitTest.java
* (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/href-5.txt
* (edit) core/src/main/java/org/apache/struts2/views/jsp/ui/SubmitTag.java
* (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/href-4.txt
* (edit)
apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/subsetIteratorTagDemoResult.jsp
* (edit) core/src/main/resources/template/simple/a-close.ftl
* (edit) apps/showcase/src/main/webapp/WEB-INF/filedownload/index.jsp
* (edit)
apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/iteratorGeneratorTagDemoResult.jsp
* (edit) core/src/main/java/org/apache/struts2/components/Anchor.java
* (edit) core/src/main/java/org/apache/struts2/components/Submit.java
* (edit) core/src/main/resources/template/simple/submit-close.ftl
* (edit) core/src/test/java/org/apache/struts2/views/jsp/ui/AnchorTest.java
* (edit)
apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/mergeIteratorTagDemoResult.jsp
* (edit) core/src/main/java/org/apache/struts2/views/jsp/ui/AnchorTag.java
* (edit) core/src/main/java/org/apache/struts2/components/Component.java
* (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/href-3.txt
* (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/Submit-11.txt
* (edit)
apps/showcase/src/main/webapp/WEB-INF/tags/non-ui/iteratorTag/appendIteratorTagDemoResult.jsp
* (edit) core/src/test/java/org/apache/struts2/components/ComponentTest.java
* (add) core/src/test/resources/org/apache/struts2/views/jsp/ui/Submit-12.txt
> Struts 2.6 escaping behaviour change for s:a (anchor) tag
> ---------------------------------------------------------
>
> Key: WW-5022
> URL: https://issues.apache.org/jira/browse/WW-5022
> Project: Struts 2
> Issue Type: Bug
> Components: Core
> Affects Versions: 2.6
> Environment: Tomcat 7.0, 8.5 using Java 8 and 11.
> Reporter: James Chaplin
> Priority: Major
> Fix For: 2.6
>
>
> While interacting with the current 2.6 Showcase application I recently
> noticed that+ the "Home" glyph icon was not displaying correctly+. Instead
> of the icon, +the page displayed the body content literally in the browser+.
> Checking the page source (view source in browser) it turns out the body
> content of the tag was HTML-escaped. I double-checked and this does not
> happen to Struts 2.5.21 (snapshot) or older 2.6 Showcase apps.
> This behaviour might affect other tags, but +it was noticed and confirmed
> with "s:a"+ (the JSP anchor tag).
> After some digging (using older commits from GitHub and building the 2.6
> Showcase app from them) it appears the automatic body escaping did not occur
> prior to January 2nd 2019, but was introduced with one of the multiple
> commits applied on January 3rd 2019.
> It could be an interaction between earlier mid-December 2018 commits that
> changed the Freemarker configuration version in FreemarkerManager
> (Configuration.VERSION_2_3_0) to a new one (Configuration.VERSION_2_3_28),
> combined with the January 3rd commits. Couldn't find the exact cause, but
> perhaps one of the Struts Team might be able to do so.
> Given the original/old behaviour +it seems that auto-escaping the tag body
> might be a bug+.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
