[
https://issues.apache.org/jira/browse/WW-4789?focusedWorklogId=431249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-431249
]
ASF GitHub Bot logged work on WW-4789:
--------------------------------------
Author: ASF GitHub Bot
Created on: 06/May/20 14:37
Start Date: 06/May/20 14:37
Worklog Time Spent: 10m
Work Description: yasserzamani commented on pull request #397:
URL: https://github.com/apache/struts/pull/397#issuecomment-624687993
Hi @JCgH4164838Gh792C124B5 ,
Thank you so much for your fix and clarification! No it's OK; I had
overlooked the revert commit owing to a pell-mell inbox ;)
Regards.
On 5/6/2020 5:58 AM, JCgH4164838Gh792C124B5 wrote:
> Hi @yasserzamani <https://github.com/yasserzamani>.
>
> Thanks for reviewing the item concerning the |java.io| exclusion list.
> 👍 Your reasoning above is sound, and the Showcase upload action was
> failing due the way one if its validation expressions was coded.
>
> The Showcase upload action was fixed in a separate PR, so it no longer
> fails with the original exclusions in place. Lukasz restored the
> |java.io| package exclusion in this PR before it was merged, so it
> should be back-to-normal now. If something was overlooked, please let us
> know. 😄
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/struts/pull/397#issuecomment-624397178>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ABL5HNV5MNZNIWEVYUFAAGDRQC4LZANCNFSM4LQ3C46A>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 431249)
Time Spent: 2h 50m (was: 2h 40m)
> ActionContext should be immutable
> ---------------------------------
>
> Key: WW-4789
> URL: https://issues.apache.org/jira/browse/WW-4789
> Project: Struts 2
> Issue Type: Improvement
> Components: Core
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Major
> Fix For: 2.6
>
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Right now ActionContext is a bag of different contexts with mixed
> responsibility. Also some of them lay in ThreadLocal variable, but some are
> accessed directly. Also it is easily to modify the internal state which
> shouldn't be possible. The context should be constant during whole action
> execution period.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
