sepe81 commented on a change in pull request #419:
URL: https://github.com/apache/struts/pull/419#discussion_r428516840



##########
File path: 
core/src/main/java/com/opensymphony/xwork2/interceptor/ParametersInterceptor.java
##########
@@ -101,7 +104,7 @@ static private int countOGNLCharacters(String s) {
     static final Comparator<String> rbCollator = new Comparator<String>() {
         public int compare(String s1, String s2) {
             int l1 = countOGNLCharacters(s1),
-                l2 = countOGNLCharacters(s2);
+                    l2 = countOGNLCharacters(s2);

Review comment:
       ```suggestion
               int l1 = countOGNLCharacters(s1);
               int l2 = countOGNLCharacters(s2);
   ```
   
   Maybe it's better (more clear) to split this into two separate assignments?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to