[
https://issues.apache.org/jira/browse/WW-5075?focusedWorklogId=463287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-463287
]
ASF GitHub Bot logged work on WW-5075:
--------------------------------------
Author: ASF GitHub Bot
Created on: 25/Jul/20 20:06
Start Date: 25/Jul/20 20:06
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on a change in pull
request #427:
URL: https://github.com/apache/struts/pull/427#discussion_r460441702
##########
File path: plugins/osgi/src/main/java/org/apache/struts2/osgi/OsgiUtil.java
##########
@@ -92,4 +92,83 @@ public static boolean containsBean(Object beanFactory,
String beanId) {
return false;
}
+
Review comment:
Hi. Thanks for the comments above, it helped point out an issue with
the cache directory creation logic. :)
In terms of using pre-existing Java version resolvers, I decided to "stay
custom" within the plugin. The main reasoning behind that was:
1) To limit additional dependencies for the plugin at runtime (sometimes
makes it more difficult to figure out why the OSGi container cannot start or
load bundles), and
2) During testing I found that we need control over how the version was
discovered, in order to be consistent with the OSGi container (with external
java version resolvers, they may return a different version value than the one
we need for the lookups to succeed).
So, for now at least, it seems safer to stick with the custom local Java
version resolvers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 463287)
Time Spent: 1.5h (was: 1h 20m)
> Upgrade OSGi to the latest version
> ----------------------------------
>
> Key: WW-5075
> URL: https://issues.apache.org/jira/browse/WW-5075
> Project: Struts 2
> Issue Type: Dependency
> Components: Plugin - OSGi
> Reporter: Lukasz Lenart
> Priority: Major
> Fix For: 2.5.24, 2.6
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Currently the OSGi plugin is using
> {code:xml}
> <dependency>
> <groupId>org.osgi</groupId>
> <artifactId>org.osgi.core</artifactId>
> <version>4.3.1</version>
> </dependency>
> {code}
> but there is a new version 6.0.0
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
