[
https://issues.apache.org/jira/browse/WW-5088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Huber updated WW-5088:
---------------------------
Summary: Empty file upload gives wrong error message (was: Empty file
uplad gives wrong error message)
> Empty file upload gives wrong error message
> -------------------------------------------
>
> Key: WW-5088
> URL: https://issues.apache.org/jira/browse/WW-5088
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.5.22
> Reporter: Greg Huber
> Priority: Minor
>
> On an empty file upload the storeLocation is null, so adds a file new
> StrutsUploadedFile(null)
> JakartaMultiPartRequest
> List fileList = new ArrayList<>(items.size());
> for (FileItem fileItem : items) {
> File storeLocation = ((DiskFileItem) fileItem).getStoreLocation();
> if (fileItem.isInMemory() && storeLocation != null &&
> !storeLocation.exists()) {
> try {
> storeLocation.createNewFile();
> } catch (IOException e) {
> LOG.error("Cannot write uploaded empty file to disk: {}",
> storeLocation.getAbsolutePath(), e);
> }
> }
> fileList.add(new StrutsUploadedFile(storeLocation));
> }
> The FileUploadInterceptor checks for a null file but not null content from
> the new StrutsUploadedFile(null).
> eg for an empty file main.js
> Error message should be:
> Error uploading: main.js
> but gives:
> Error setting expression 'uploadedFiles' with value
> ['org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@202585bc', ]
> Error setting expression 'uploadedFiles' with value
> ['org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@49553150', ]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
