[
https://issues.apache.org/jira/browse/WW-5088?focusedWorklogId=500542&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-500542
]
ASF GitHub Bot logged work on WW-5088:
--------------------------------------
Author: ASF GitHub Bot
Created on: 14/Oct/20 09:03
Start Date: 14/Oct/20 09:03
Worklog Time Spent: 10m
Work Description: pys-arhs opened a new pull request #441:
URL: https://github.com/apache/struts/pull/441
Add integration test to detect regressions if commons-fileupload behavior
changes in the future.
DiskFileItemFactory#setSizeThreshold should be set to -1 because
org.apache.commons.io.output.ThresholdingOutputStream#checkThreshold checks if
the current file size is strictly greater than the threshold.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 500542)
Time Spent: 1.5h (was: 1h 20m)
> Empty file upload gives wrong error message
> -------------------------------------------
>
> Key: WW-5088
> URL: https://issues.apache.org/jira/browse/WW-5088
> Project: Struts 2
> Issue Type: Bug
> Components: Core Interceptors
> Affects Versions: 2.5.22
> Reporter: Greg Huber
> Priority: Minor
> Fix For: 2.6
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> On an empty file upload the storeLocation is null, so adds a file new
> StrutsUploadedFile(null)
> JakartaMultiPartRequest
> {code:java}
> List fileList = new ArrayList<>(items.size());
> for (FileItem fileItem : items) {
> File storeLocation = ((DiskFileItem) fileItem).getStoreLocation();
> if (fileItem.isInMemory() && storeLocation != null &&
> !storeLocation.exists()) {
> try {
> storeLocation.createNewFile();
> } catch (IOException e) {
> LOG.error("Cannot write uploaded empty file to disk: {}",
> storeLocation.getAbsolutePath(), e);
> }
> }
> fileList.add(new StrutsUploadedFile(storeLocation));
> }
> {code}
> The FileUploadInterceptor checks for a null file but not null content from
> the new StrutsUploadedFile(null).
> eg for an empty file main.js
> Error message should be:
> Error uploading: main.js
> but gives:
> Error setting expression 'uploadedFiles' with value
> ['org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@202585bc', ]
> Error setting expression 'uploadedFiles' with value
> ['org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@49553150', ]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
