lcc commented on pull request #445: URL: https://github.com/apache/struts/pull/445#issuecomment-726109984
Hi @lukaszlenart thanks for the prompt response. The error that causes the pipeline to fail is "ClassNotFoundException org.apache.maven.surefire.booter.ForkedBooter" which also happens in the current master build. This is a [well known error](https://issues.apache.org/jira/browse/SUREFIRE-1588) in the maven surefire plugin, in order to "fix" this one must update to a surefire version to one that corrected this, such as 3.0.0-M1. After updating it on my surefire-plugin, this issue ceases to exist and all tests pass. This PR was purely meant to fix unecessary uses of the close method, but if you want I can write a patch for the surefire-plugin. I didn't do it before because there may be some underlying reason to use it the way it's being used. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
