akash5885 commented on a change in pull request #446:
URL: https://github.com/apache/struts/pull/446#discussion_r523417890
##########
File path:
core/src/main/java/com/opensymphony/xwork2/interceptor/StaticParametersInterceptor.java
##########
@@ -237,7 +237,8 @@ protected void addParametersToContext(ActionContext ac,
Map<String, ?> newParams
}
} else {
if (newParams != null) {
- combinedParams = combinedParams.withExtraParams(newParams);
+ HttpParameters newHttpParameters =
HttpParameters.create(newParams).build();
+ combinedParams = combinedParams.withParent(newHttpParameters);
}
if (previousParams != null) {
combinedParams = combinedParams.withParent(previousParams);
Review comment:
@lukaszlenart I think for this one means for previous params,
combinedParams.withParent(previousParams) needs to replace with
combinedParams.withExtraParams(previousParams) otherwise extra parameters which
are in newParams and not in previousParams will be lost.
Please let me know if I'm missing anything here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
