[
https://issues.apache.org/jira/browse/WW-5093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17252275#comment-17252275
]
ASF GitHub Bot commented on WW-5093:
------------------------------------
JCgH4164838Gh792C124B5 commented on pull request #154:
URL: https://github.com/apache/struts-site/pull/154#issuecomment-748528953
Hello @yasserzamani and @lukaszlenart .
Thanks for the information on the staged site, as that really helps
confirming the output. 😄
I applied the paragraph blocking that was requested, and made an extra
mention of "attr" on the set-tag page along with the page-scope items. I think
the latter might help developers more easily remember the association for attr
and page-scope that way ?
Let me know if it looks OK now, or if more changes would improve it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> inconsistent scope for variables created with s:set and s:url
> -------------------------------------------------------------
>
> Key: WW-5093
> URL: https://issues.apache.org/jira/browse/WW-5093
> Project: Struts 2
> Issue Type: Bug
> Components: Core Tags
> Affects Versions: 2.5.22
> Reporter: nikos dimitrakas
> Priority: Major
> Labels: scope, tag, var
> Fix For: 2.6
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The implementation of s:set and s:url and s:text is not consistent and not
> well documented.Â
> Creating a variable with s:set puts the variable in a different default scope
> than creating a variable with s:url or s:text (with the attribute var). It is
> also not documented what the default scope is. After testing I could conclude
> that the scope for a variable created by s:url is request, while the default
> of s:set is not. Furthermore, s:set offers a possibility to specify the scope
> with an attribute, But s:url and s:text do not.Â
> Possible options would be offering the possibility to specify the scope
> attribute in s:url and s:text, or dropping support for the var attribute for
> s:url and s:text and only allow s:set to create variables (thus being forced
> to nest s:url and s:text inside an s:set). That would be symmetric with how
> s:property does not offer the var attribute. At minimum all three tags should
> have the same default and their default should be explicitly specified in the
> documentation (in the tld and the online manual / tag reference)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
