[
https://issues.apache.org/jira/browse/WW-5063?focusedWorklogId=528178&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-528178
]
ASF GitHub Bot logged work on WW-5063:
--------------------------------------
Author: ASF GitHub Bot
Created on: 24/Dec/20 15:05
Start Date: 24/Dec/20 15:05
Worklog Time Spent: 10m
Work Description: coveralls commented on pull request #461:
URL: https://github.com/apache/struts/pull/461#issuecomment-750906054
[](https://coveralls.io/builds/35936731)
Coverage decreased (-0.002%) to 49.777% when pulling
**f2540192bf560892cdfb7d6a49b97684a0c2cf48 on WW-5063-null-check** into
**7532d2fb0d6081a12c2a48ec854a81a8b718be62 on master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 528178)
Time Spent: 20m (was: 10m)
> Use null check of passed in invocation in all the results
> ---------------------------------------------------------
>
> Key: WW-5063
> URL: https://issues.apache.org/jira/browse/WW-5063
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Results
> Reporter: Lukasz Lenart
> Assignee: Lukasz Lenart
> Priority: Minor
> Fix For: 2.6
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now in most cases passed in {{invocation}} isn't validated if it isn't
> {{null}}, the below code should be applied to all {{Result}}s
> {code}
> if (invocation == null) {
> throw new IllegalArgumentException("invocation cannot be null!");
> }
> {code}
> This was pointed out during a PR review
> https://github.com/apache/struts/pull/397/files#r396134222
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
