[ 
https://issues.apache.org/jira/browse/WW-5063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254575#comment-17254575
 ] 

ASF subversion and git services commented on WW-5063:
-----------------------------------------------------

Commit fbdcd2c4a7ee2ec62da3cfa9f7b2d587f34d813f in struts's branch 
refs/heads/WW-5063-null-check from Lukasz Lenart
[ https://gitbox.apache.org/repos/asf?p=struts.git;h=fbdcd2c ]

WW-5063 Adds tests to cover new functionality


> Use null check of passed in invocation in all the results
> ---------------------------------------------------------
>
>                 Key: WW-5063
>                 URL: https://issues.apache.org/jira/browse/WW-5063
>             Project: Struts 2
>          Issue Type: Improvement
>          Components: Core Results
>            Reporter: Lukasz Lenart
>            Assignee: Lukasz Lenart
>            Priority: Minor
>             Fix For: 2.6
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Right now in most cases passed in {{invocation}} isn't validated if it isn't 
> {{null}}, the below code should be applied to all {{Result}}s
> {code}
> if (invocation == null) {
>     throw new IllegalArgumentException("invocation cannot be null!");
> }
> {code}
> This was pointed out during a PR review
> https://github.com/apache/struts/pull/397/files#r396134222



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to