sepe81 commented on a change in pull request #464:
URL: https://github.com/apache/struts/pull/464#discussion_r551425829
##########
File path: core/src/main/java/com/opensymphony/xwork2/ObjectFactory.java
##########
@@ -68,7 +69,7 @@ public void setContainer(Container container) {
this.container = container;
}
- @Inject(value="objectFactory.classloader", required=false)
+ @Inject(value= StrutsConstants.STRUTS_OBJECT_FACTORY_CLASSLOADER,
required=false)
Review comment:
```suggestion
@Inject(value=StrutsConstants.STRUTS_OBJECT_FACTORY_CLASSLOADER,
required=false)
```
##########
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
##########
@@ -284,7 +284,7 @@ protected Container
createBootstrapContainer(List<ContainerProvider> providers)
builder.factory(ValueSubstitutor.class, EnvsValueSubstitutor.class,
Scope.SINGLETON);
builder.constant(StrutsConstants.STRUTS_DEVMODE, "false");
- builder.constant(StrutsConstants.STRUTS_LOG_MISSING_PROPERTIES,
"false");
+ builder.constant(StrutsConstants.STRUTS_OGNL_LOG_MISSING_PROPERTIES,
"false");
Review comment:
Does this mean, the OGNL log constant is preferred over the non OGNL
constant?
##########
File path: core/src/main/java/org/apache/struts2/StrutsConstants.java
##########
@@ -346,4 +346,9 @@
/** See {@link
com.opensymphony.xwork2.config.impl.AbstractMatcher#appendNamedParameters */
public static final String STRUTS_MATCHER_APPEND_NAMED_PARAMETERS =
"struts.matcher.appendNamedParameters";
+
+ public static final String STRUTS_CHAINING_COPY_ERRORS =
"struts.chaining.copyErrors";
Review comment:
I guess according to
https://issues.apache.org/jira/browse/WW-5000?focusedCommentId=17257465&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17257465
the removal of `xwork.` is intentional?
struts.xwork.chaining.copyErrors gets struts.chaining.copyErrors
##########
File path:
core/src/main/java/com/opensymphony/xwork2/config/impl/DefaultConfiguration.java
##########
@@ -284,7 +284,7 @@ protected Container
createBootstrapContainer(List<ContainerProvider> providers)
builder.factory(ValueSubstitutor.class, EnvsValueSubstitutor.class,
Scope.SINGLETON);
builder.constant(StrutsConstants.STRUTS_DEVMODE, "false");
- builder.constant(StrutsConstants.STRUTS_LOG_MISSING_PROPERTIES,
"false");
+ builder.constant(StrutsConstants.STRUTS_OGNL_LOG_MISSING_PROPERTIES,
"false");
Review comment:
Oh, I see it is a rename under
https://github.com/apache/struts/pull/464/files#diff-2de2f780034a74f8de7c95a0a38f6bea1c97cff74d7060064f28dc6069a24a44
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
