[
https://issues.apache.org/jira/browse/WW-5124?focusedWorklogId=607602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-607602
]
ASF GitHub Bot logged work on WW-5124:
--------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jun/21 03:21
Start Date: 07/Jun/21 03:21
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on pull request #489:
URL: https://github.com/apache/struts/pull/489#issuecomment-855547053
Hello Apache Struts Team.
This PR ended up involving many more files than originally planned, due to
the number of unit test changes that were made. This is a first draft attempt
to find a solution to the behaviour issue seen with tag pooling application
servers, but others who review it may be able to point to a better alternative.
Interactive tests with Glassfish 5.0.1 appear to show the idea works, and
the Showcase application seems to also work properly too. The call overhead of
these changes may exceed the benefits, but should make the JSP tag behaviour
correct (or mostly correct) when tag class instances are re-used by tag pools.
If anyone has suggestions on improvements, or alternatives, please let me
know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 607602)
Time Spent: 0.5h (was: 20m)
> Tag attribute values cached
> ---------------------------
>
> Key: WW-5124
> URL: https://issues.apache.org/jira/browse/WW-5124
> Project: Struts 2
> Issue Type: Bug
> Environment: Here you have a repo that reproduce this:
> https://github.com/dfliess/struts2-tagpooling-bug
> Reporter: Diego Alejandro Fliess
> Priority: Major
> Fix For: 2.5.27, 2.6
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> On some application servers, like glassfish, when handling jsp tag pooling,
> attribute values are cached or not reinitiallized.
> For example:
> {code:java}
> <s:textfield size="50">
> <jsp:attribute name="placeholder">THIS TEXTFIELD SHOULD HAVE
> VALUE</jsp:attribute>
> <jsp:attribute name="value">VALUE</jsp:attribute>
> </s:textfield>
> <s:textfieldsize="50">
> <jsp:attribute name="placeholder">THIS TEXT FIELD SHOULDN'T HAVE
> VALUE</jsp:attribute>
> </s:textfield>{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
