[
https://issues.apache.org/jira/browse/WW-5132?focusedWorklogId=617430&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617430
]
ASF GitHub Bot logged work on WW-5132:
--------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 07:10
Start Date: 01/Jul/21 07:10
Worklog Time Spent: 10m
Work Description: yasserzamani commented on a change in pull request #492:
URL: https://github.com/apache/struts/pull/492#discussion_r662036628
##########
File path: core/src/main/java/org/apache/struts2/components/UIBean.java
##########
@@ -689,7 +689,9 @@ public void evaluateParams() {
}
if (labelPosition != null) {
- addParameter("labelposition", findString(labelPosition));
+ String labelPosition = findString(this.labelPosition);
+ addParameter("labelposition", labelPosition);
Review comment:
Not sure but I think not required anymore as all usages in all ftl files
are removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617430)
Time Spent: 1h 10m (was: 1h)
> Make labelposition deprecated
> -----------------------------
>
> Key: WW-5132
> URL: https://issues.apache.org/jira/browse/WW-5132
> Project: Struts 2
> Issue Type: Improvement
> Components: Core Tags
> Reporter: Lukasz Lenart
> Priority: Minor
> Fix For: 2.5.27
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{labelposition}} is deprecated, please use {{labelPosition}} attribute
> instead - it will be removed in
> [2.6.1|https://issues.apache.org/jira/browse/WW-5133]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
