JCgH4164838Gh792C124B5 commented on pull request #489: URL: https://github.com/apache/struts/pull/489#issuecomment-927385594
Hi @yasserzamani . Thanks for pointing out the possibility that `ThreadLocal` side-effects were at play. 👏 I implemented changes similar to what you suggested (but applied the clear/reset to `StrutsInternalTestCase` instead), and the automated build finally passed again. This PR probably now has the elements needed for a flexible solution, but it is a lot more changes than I had envisioned at the start. I am not sure the tag control flag name is very elegant, and there may be some "rough edges", but the idea can be seen at least. From recent discussion, it seems like the intent may be to re-target open PR changes against the 2.6 branch instead. It should be possible to do so with the ideas in this PR, but could take a bit of time . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
