[
https://issues.apache.org/jira/browse/WW-5124?focusedWorklogId=655316&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-655316
]
ASF GitHub Bot logged work on WW-5124:
--------------------------------------
Author: ASF GitHub Bot
Created on: 26/Sep/21 22:50
Start Date: 26/Sep/21 22:50
Worklog Time Spent: 10m
Work Description: JCgH4164838Gh792C124B5 commented on pull request #489:
URL: https://github.com/apache/struts/pull/489#issuecomment-927385594
Hi @yasserzamani .
Thanks for pointing out the possibility that `ThreadLocal` side-effects were
at play. 👏
I implemented changes similar to what you suggested (but applied the
clear/reset to `StrutsInternalTestCase` instead), and the automated build
finally passed again.
This PR probably now has the elements needed for a flexible solution, but it
is a lot more changes than I had envisioned at the start. I am not sure the
tag control flag name is very elegant, and there may be some "rough edges", but
the idea can be seen at least.
From recent discussion, it seems like the intent may be to re-target open PR
changes against the 2.6 branch instead. It should be possible to do so with
the ideas in this PR, but could take a bit of time .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 655316)
Time Spent: 3h (was: 2h 50m)
> Tag attribute values cached
> ---------------------------
>
> Key: WW-5124
> URL: https://issues.apache.org/jira/browse/WW-5124
> Project: Struts 2
> Issue Type: Bug
> Environment: Here you have a repo that reproduce this:
> https://github.com/dfliess/struts2-tagpooling-bug
> Reporter: Diego Alejandro Fliess
> Priority: Major
> Fix For: 2.6, 2.5.28
>
> Time Spent: 3h
> Remaining Estimate: 0h
>
> On some application servers, like glassfish, when handling jsp tag pooling,
> attribute values are cached or not reinitiallized.
> For example:
> {code:java}
> <s:textfield size="50">
> <jsp:attribute name="placeholder">THIS TEXTFIELD SHOULD HAVE
> VALUE</jsp:attribute>
> <jsp:attribute name="value">VALUE</jsp:attribute>
> </s:textfield>
> <s:textfieldsize="50">
> <jsp:attribute name="placeholder">THIS TEXT FIELD SHOULDN'T HAVE
> VALUE</jsp:attribute>
> </s:textfield>{code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
