yasserzamani commented on pull request #496:
URL: https://github.com/apache/struts/pull/496#issuecomment-932938755
@lukaszlenart I double checked and host of them are additions or just java
language improvements. Existing tests' functional changes are:
```diff
-assertEquals(bean.escape("hello!world"), "hello!world");
-assertEquals(bean.escape("hello!@#$%^&*()world"), "hello!@#$%^&*()world");
+assertEquals(bean.escape("hello!world"), "hello_world");
+assertEquals(bean.escape("hello!@#$%^&*()world"), "hello__________world");
```
which isn't a breaking changes because it's an Struts' internal change.
```diff
-tag.setId("cb.bc");
+tag.setId("cb['\".\"'] = bc(){};//");
```
and consequently
```diff
-<td class="tdLabel"><label for="cb.bc" class="label">mylabel:</label></td>
+<td class="tdLabel"><label for="cb['"."']=bc(){};//"
class="label">mylabel:</label></td>
...
-function autoPopulate_cb_bc(targetElement) {
+function autoPopulate_cb__________bc_______(targetElement) {
-<input type="text" name="foo" value="hello" id="cb.bc"/><br/>
-<select onChange="autoPopulate_cb_bc(this);">
+<input type="text" name="foo" value="hello"
id="cb['"."']=bc(){};//"/><br/>
+<select onChange="autoPopulate_cb__________bc_______(this);">
```
which isn't a breaking changes because it's an Struts' internal change.
```diff
- <input type="radio" name="myMap['name']"
id="myMap_'name'_"value=""/>
- <label for="myMap_'name'_">N/A</label>
- <input type="radio" name="myMap['name']" id="myMap_'name'_Opt."
value="Opt."/>
- <label for="myMap_'name'_Opt.">Opt.</label>
- <input type="radio" name="myMap['name']" id="myMap_'name'_Std."
checked="checked" value="Std."/>
- <label for="myMap_'name'_Std.">Std.</label>
+ <input type="radio" name="myMap['name']" id="myMap__name__"value=""/>
+ <label for="myMap__name__">N/A</label>
+ <input type="radio" name="myMap['name']" id="myMap__name__Opt."
value="Opt."/>
+ <label for="myMap__name__Opt.">Opt.</label>
+ <input type="radio" name="myMap['name']" id="myMap__name__Std."
checked="checked" value="Std."/>
+ <label for="myMap__name__Std.">Std.</label>
```
which isn't a breaking changes because it's an Struts' internal change.
BTW can I merge at my own risk and responsibility? @apache/struts-committers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
