yyfMichaelYan commented on a change in pull request #506:
URL: https://github.com/apache/struts/pull/506#discussion_r749566563
##########
File path:
core/src/test/java/org/apache/struts2/views/freemarker/FreemarkerResultMockedTest.java
##########
@@ -113,15 +113,16 @@ public void testDynamicAttributesSupport() throws
Exception {
ActionMapping mapping =
container.getInstance(ActionMapper.class).getMapping(request,
configurationManager);
dispatcher.serviceAction(request, response, mapping);
- String expected =
- "<input type=\"text\" name=\"test\" value=\"\" id=\"test\"
foo=\"bar\" placeholder=\"input\"/>"
- + "<input type=\"text\" name=\"test\" value=\"\" id=\"test\"
foo=\"bar\" placeholder=\"input\"/>"
- + "<input type=\"text\" name=\"test\" value=\"\" id=\"test\"
break=\"true\"/>"
- + "<input type=\"text\" name=\"required\" value=\"\"
id=\"required\" required=\"true\"/>";
+ String input1 = "<input type=\"text\" name=\"test\" value=\"\"
id=\"test\" foo=\"bar\" placeholder=\"input\"/>";
+ String input2 = "<input type=\"text\" name=\"test\" value=\"\"
id=\"test\" placeholder=\"input\" foo=\"bar\"/>";
+ String input34 = "<input type=\"text\" name=\"test\" value=\"\"
id=\"test\" break=\"true\"/>"
+ + "<input type=\"text\" name=\"required\" value=\"\"
id=\"required\" required=\"true\"/>";
String result = stringWriter.toString();
-
- assertEquals(expected, result);
+ assertTrue(result.equals(input1 + input1 + input34)
+ || result.equals(input1 + input2 + input34)
+ || result.equals(input2 + input1 + input34)
+ || result.equals(input2 + input2 + input34));
Review comment:
Hi Sebastian! Actually, you can also add an error message to
```assertTrue```. The signature of this method is ```TestCase.assertTrue(String
message, boolean condition) : void```. I didn't add it because the initial
assertion doesn't come with one. If you think it's better to have an error
message, I can definitely add it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
